menushell: Fix select_last() to get last, not 1st
authorDaniel Boles <dboles@src.gnome.org>
Sat, 21 Jan 2017 18:53:38 +0000 (18:53 +0000)
committerDaniel Boles <dboles@src.gnome.org>
Sat, 21 Jan 2017 18:55:46 +0000 (18:55 +0000)
It was broken in the same way as select_first(), as explained in
commit a5211adb225172195d6778d652b58632c38afcbf

gtk/gtkmenushell.c

index d2e86856312312796cac5c9ffc841fcea47556b0..9bab5ed16f0075d8f39ed64b25f7aa09c19f3bdc 100644 (file)
@@ -1439,7 +1439,6 @@ _gtk_menu_shell_select_last (GtkMenuShell *menu_shell,
                              gboolean      search_sensitive)
 {
   GtkMenuShellPrivate *priv = menu_shell->priv;
-  GtkWidget *to_select = NULL;
   GList *tmp_list;
 
   tmp_list = g_list_last (priv->children);
@@ -1450,14 +1449,12 @@ _gtk_menu_shell_select_last (GtkMenuShell *menu_shell,
       if ((!search_sensitive && gtk_widget_get_visible (child)) ||
           _gtk_menu_item_is_selectable (child))
         {
-          to_select = child;
+          gtk_menu_shell_select_item (menu_shell, child);
+          return;
         }
 
       tmp_list = tmp_list->prev;
     }
-
-  if (to_select)
-    gtk_menu_shell_select_item (menu_shell, to_select);
 }
 
 static gboolean